Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-Queryparams: Add addon preset #9949

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

jonspalmer
Copy link
Contributor

What I did

Added a preset for QueryParams addon allowing simpler configuration

@jonspalmer jonspalmer added this to the 6.0.0 milestone Feb 25, 2020
@shilman
Copy link
Member

shilman commented Feb 26, 2020

@ndelangen tests are running out of memory... any idea what's up with that?

@ndelangen
Copy link
Member

which test is running out of memory?

I'm not seeing any substantial change that might be the cause of any memory issues in tests tbh.

@jonspalmer
Copy link
Contributor Author

this run failed: https://circleci.com/gh/storybookjs/storybook/199948

CircleCI tests sometimes flake out. I've seen it in other branches too. In my experience there is a lot of variability in the nodes running the test suite (I believe they're using a bunch of containers in different regions/cloud providers). Some nodes miss caches others are just 'not as good'. I bet we're running close to the memory limit of the basic test node and every now an then get unlucky. We could opt for medium+ resources on CircleCI but that would likely add 50% to our credit usage (maybe the tests get faster with more RAM to compensate?)

@jonspalmer
Copy link
Contributor Author

Running the test command locally that we use on CircleCI I see the the two threads end up using about 2GB of RAM each. So on a medium instance we're right up against it (https://circleci.com/docs/2.0/configuration-reference/#resource_class)

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great fix 💯

@shilman shilman changed the title QueryParams addon preset Addon-Queryparams: Add addon preset Feb 28, 2020
@shilman shilman merged commit 8657d7d into storybookjs:next Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants